[webkit-reviews] review granted: [Bug 229664] add logging for IPC messages : [Attachment 437213] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has granted Cameron McCormack
(:heycam) <heycam at apple.com>'s request for review:
Bug 229664: add logging for IPC messages
https://bugs.webkit.org/show_bug.cgi?id=229664

Attachment 437213: Patch

https://bugs.webkit.org/attachment.cgi?id=437213&action=review




--- Comment #13 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 437213
  --> https://bugs.webkit.org/attachment.cgi?id=437213
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=437213&action=review

> Source/WTF/wtf/text/TextStream.h:233
> +	   if (i)

nit: I think it would be nice if this had the same style as the other two below
and checked count here and used a c++11-style for ( : ) loop

> Source/WTF/wtf/text/TextStream.h:356
> +struct ValueOrFallback {

This is only ever used with "..." as the fallback.  Do we need something this
generic, or could we do ValueOrEllipsis?

> Source/WebKit/Platform/IPC/HandleMessage.h:51
> +enum class ForReply { No, Yes };

nit: : bool