[webkit-reviews] review granted: [Bug 229971] run_webkit_tests failed to print error message in python3 in linux_get_crash_log.py : [Attachment 437503] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 7 08:09:32 PDT 2021


Aakash Jain <aakash_jain at apple.com> has granted Jonathan Bedard
<jbedard at apple.com>'s request for review:
Bug 229971: run_webkit_tests failed to print error message in python3 in
linux_get_crash_log.py
https://bugs.webkit.org/show_bug.cgi?id=229971

Attachment 437503: Patch

https://bugs.webkit.org/attachment.cgi?id=437503&action=review




--- Comment #2 from Aakash Jain <aakash_jain at apple.com> ---
Comment on attachment 437503
  --> https://bugs.webkit.org/attachment.cgi?id=437503
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=437503&action=review

> Tools/Scripts/webkitpy/port/linux_get_crash_log.py:63
> +	       stdout = (b'ERROR: The gdb process exited with non-zero return
code %s\n\n' % str(proc.returncode)) + stdout

should we use {} and .format() instead of %s


More information about the webkit-reviews mailing list