[webkit-reviews] review granted: [Bug 229960] Add layout test for performance of adding children to a shadow host : [Attachment 437426] patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Antti Koivisto <koivisto at iki.fi>'s
request for review:
Bug 229960: Add layout test for performance of adding children to a shadow host
https://bugs.webkit.org/show_bug.cgi?id=229960

Attachment 437426: patch

https://bugs.webkit.org/attachment.cgi?id=437426&action=review




--- Comment #3 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 437426
  --> https://bugs.webkit.org/attachment.cgi?id=437426
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=437426&action=review

> LayoutTests/fast/shadow-dom/host-child-append-performance.html:11
> +for (i = 0; i < 10000; ++i)
> +    host.appendChild(document.createElement("div"));

Wouldn't this test start passing on a very fast machine even if this got broken
or start failing on a very slow machine without any regression?
I guess there is no way around it.