[webkit-reviews] review granted: [Bug 225850] [PATCH] fix webkitgtk build on macOS : [Attachment 437405] Combined patch

[bugzilla-daemon at webkit.org]

Michael Catanzaro <mcatanzaro at gnome.org> has granted Dmitry Kalinkin
<veprbl+webkit at gmail.com>'s request for review:
Bug 225850: [PATCH] fix webkitgtk build on macOS
https://bugs.webkit.org/show_bug.cgi?id=225850

Attachment 437405: Combined patch

https://bugs.webkit.org/attachment.cgi?id=437405&action=review




--- Comment #9 from Michael Catanzaro <mcatanzaro at gnome.org> ---
Comment on attachment 437405
  --> https://bugs.webkit.org/attachment.cgi?id=437405
Combined patch

View in context: https://bugs.webkit.org/attachment.cgi?id=437405&action=review

It's probably been a long time since somebody got WebKitGTK to build on macOS.
Impressive!

Your changes all look fine to me. I'm just going to leave nits about the line
spacing.

> Source/WebKit/ChangeLog:8
> +	   implementations to allow compiling webkitgtk on macOS.
> +	   https://bugs.webkit.org/show_bug.cgi?id=225850

There should be one blank line in the ChangeLog above the URL.

> Source/WebKit/Platform/IPC/unix/ConnectionUnix.cpp:50
> +#endif
>  // Although it's available on Darwin, SOCK_SEQPACKET seems to work
differently

Leave a blank line here, please.