[webkit-reviews] review granted: [Bug 229915] [css-masking] Add a temporarily prefixed property for mask-mode, aliased to -webkit-mask-source-type : [Attachment 437367] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 6 01:34:51 PDT 2021


Antti Koivisto <koivisto at iki.fi> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 229915: [css-masking] Add a temporarily prefixed property for mask-mode,
aliased to -webkit-mask-source-type
https://bugs.webkit.org/show_bug.cgi?id=229915

Attachment 437367: Patch

https://bugs.webkit.org/attachment.cgi?id=437367&action=review




--- Comment #7 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 437367
  --> https://bugs.webkit.org/attachment.cgi?id=437367
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=437367&action=review

> Source/WebCore/css/makeprop.pl:306
>		       $nameToAliases{$name} = $codegenProperties->{"aliases"};
> +		   } elsif ($codegenOptionName eq "synonym") {
> +		     $synonyms{$name} = 1;
> +		     push @{$namesToSynonyms{$codegenProperties->{"synonym"}}},
$name;
>		   } elsif ($styleBuilderOptions{$codegenOptionName}) {

weird indentation


More information about the webkit-reviews mailing list