[webkit-reviews] review granted: [Bug 229887] Simplify PCM::Client interface : [Attachment 437303] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 3 15:13:34 PDT 2021


Kate Cheney <katherine_cheney at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 229887: Simplify PCM::Client interface
https://bugs.webkit.org/show_bug.cgi?id=229887

Attachment 437303: Patch

https://bugs.webkit.org/attachment.cgi?id=437303&action=review




--- Comment #2 from Kate Cheney <katherine_cheney at apple.com> ---
Comment on attachment 437303
  --> https://bugs.webkit.org/attachment.cgi?id=437303
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=437303&action=review

r=me

>
Source/WebKit/NetworkProcess/PrivateClickMeasurement/PrivateClickMeasurementNet
workLoader.cpp:50
> +	  
request.setHTTPBody(WebCore::FormData::create(jsonPayload->toJSONString().utf8(
)));

You dropped a .data() here, was that intentional?


More information about the webkit-reviews mailing list