[webkit-reviews] review granted: [Bug 229885] [macCatalyst] Support photo picker and camera actions for file inputs : [Attachment 437304] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Aditya Keerthi
<akeerthi at apple.com>'s request for review:
Bug 229885: [macCatalyst] Support photo picker and camera actions for file
inputs
https://bugs.webkit.org/show_bug.cgi?id=229885

Attachment 437304: Patch

https://bugs.webkit.org/attachment.cgi?id=437304&action=review




--- Comment #4 from Tim Horton <thorton at apple.com> ---
Comment on attachment 437304
  --> https://bugs.webkit.org/attachment.cgi?id=437304
Patch

It seems slightly odd to me that we would make macCatalyst WebKit and macOS
WebKit do different things when you click a file input, but I don't know if
that means "macOS WebKit should get an image picker" or "macCatalyst WebKit
should just go straight to NSOpenPanel". Regardless, that should be an explicit
decision instead of a random ifdef about missing API, so I guess this is a
change in a good /direction/.