[webkit-reviews] review granted: [Bug 229703] [JSC] Implement Temporal.TimeZone : [Attachment 437253] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 3 10:52:18 PDT 2021


Ross Kirsling <ross.kirsling at sony.com> has granted Yusuke Suzuki
<ysuzuki at apple.com>'s request for review:
Bug 229703: [JSC] Implement Temporal.TimeZone
https://bugs.webkit.org/show_bug.cgi?id=229703

Attachment 437253: Patch

https://bugs.webkit.org/attachment.cgi?id=437253&action=review




--- Comment #7 from Ross Kirsling <ross.kirsling at sony.com> ---
Comment on attachment 437253
  --> https://bugs.webkit.org/attachment.cgi?id=437253
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=437253&action=review

r=me

> Source/JavaScriptCore/runtime/TemporalTimeZone.cpp:36
> +static constexpr bool verbose = false;

Seems like you're not actually using this at present.

> Source/JavaScriptCore/runtime/TemporalTimeZonePrototype.cpp:31
> +#include "IntlObject.h"

Looks like you're already getting this from TemporalTimeZone.h.


More information about the webkit-reviews mailing list