[webkit-reviews] review granted: [Bug 229853] [JSC] Fix WebKitAdditions directory traversal in offlineasm part 2 : [Attachment 437251] Patch

[bugzilla-daemon at webkit.org]

Mark Lam <mark.lam at apple.com> has granted Yusuke Suzuki <ysuzuki at apple.com>'s
request for review:
Bug 229853: [JSC] Fix WebKitAdditions directory traversal in offlineasm part 2
https://bugs.webkit.org/show_bug.cgi?id=229853

Attachment 437251: Patch

https://bugs.webkit.org/attachment.cgi?id=437251&action=review




--- Comment #2 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 437251
  --> https://bugs.webkit.org/attachment.cgi?id=437251
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=437251&action=review

r=me

> Source/JavaScriptCore/offlineasm/asm.rb:343
> +    opts.on("--webkit-additions-path=PATH", "Flag to use deployment
location.") do |path|

Can you change “Flag to use deployment location” to “WebKitAdditions path”?

> Source/JavaScriptCore/offlineasm/generate_offset_extractor.rb:52
> +    opts.on("--webkit-additions-path=PATH", "Flag to use deployment
location.") do |path|

Ditto.

> Source/JavaScriptCore/offlineasm/generate_settings_extractor.rb:49
> +    opts.on("--webkit-additions-path=PATH", "Flag to use deployment
location.") do |path|

Ditto.