[webkit-reviews] review granted: [Bug 228914] [css-writing-modes] Fix absolutely positioning with orthogonal writing modes : [Attachment 437168] Patch

[bugzilla-daemon at webkit.org]

Manuel Rego Casasnovas <rego at igalia.com> has granted Sergio Villar Senin
<svillar at igalia.com>'s request for review:
Bug 228914: [css-writing-modes] Fix absolutely positioning with orthogonal
writing modes
https://bugs.webkit.org/show_bug.cgi?id=228914

Attachment 437168: Patch

https://bugs.webkit.org/attachment.cgi?id=437168&action=review




--- Comment #20 from Manuel Rego Casasnovas <rego at igalia.com> ---
Comment on attachment 437168
  --> https://bugs.webkit.org/attachment.cgi?id=437168
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=437168&action=review

Awesome patch, that improves a lot of cases. r=me

> Source/WebCore/rendering/RenderBox.cpp:3693
> +static inline bool isOrthogonal(const RenderObject& renderer, const
RenderObject& ancestor)

Nit: If it doesn't have to be an ancestor, then maybe use "other" or something
like that.