[webkit-reviews] review granted: [Bug 229838] WebKitTestRunner does not correctly close all auxiliary WebViews between tests : [Attachment 437228] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has granted Chris Dumez
<cdumez at apple.com>'s request for review:
Bug 229838: WebKitTestRunner does not correctly close all auxiliary WebViews
between tests
https://bugs.webkit.org/show_bug.cgi?id=229838

Attachment 437228: Patch

https://bugs.webkit.org/attachment.cgi?id=437228&action=review




--- Comment #7 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 437228
  --> https://bugs.webkit.org/attachment.cgi?id=437228
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=437228&action=review

> Tools/DumpRenderTree/mac/DumpRenderTree.mm:1992
> +	   NSArray* array = [DumpRenderTreeWindow openWindows];
> +	   unsigned count = [array count];
> +	   for (unsigned i = 0; i < count; i++) {
> +	       NSWindow *window = [array objectAtIndex:i];

for (NSWindow *window in DumpRenderTreeWindow.openWindows)
A lot of code below could also use dot syntax.

> Tools/DumpRenderTree/win/DumpRenderTree.cpp:1333
>	   Vector<HWND> windows = openWindows();
>	   unsigned size = windows.size();
>	   for (unsigned i = 0; i < size; i++) {

for (HWND window : openWindows())
Also, there's now an unnecessary scope.