[webkit-reviews] review denied: [Bug 229841] [JSC] Fix WebKitAdditions directory traversal in offlineasm : [Attachment 437219] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 2 17:18:55 PDT 2021


Mark Lam <mark.lam at apple.com> has denied  review:
Bug 229841: [JSC] Fix WebKitAdditions directory traversal in offlineasm
https://bugs.webkit.org/show_bug.cgi?id=229841

Attachment 437219: Patch

https://bugs.webkit.org/attachment.cgi?id=437219&action=review




--- Comment #4 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 437219
  --> https://bugs.webkit.org/attachment.cgi?id=437219
Patch

You missed one spot in parser.rb: search for
"/usr/local/include/WebKitAdditions/" and you'll see a seconds place the path
is chosen in `def parseIncludes(final, comment)`.


More information about the webkit-reviews mailing list