[webkit-reviews] review granted: [Bug 229841] [JSC] Fix WebKitAdditions directory traversal in offlineasm : [Attachment 437219] Patch

[bugzilla-daemon at webkit.org]

Mark Lam <mark.lam at apple.com> has granted Yusuke Suzuki <ysuzuki at apple.com>'s
request for review:
Bug 229841: [JSC] Fix WebKitAdditions directory traversal in offlineasm
https://bugs.webkit.org/show_bug.cgi?id=229841

Attachment 437219: Patch

https://bugs.webkit.org/attachment.cgi?id=437219&action=review




--- Comment #2 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 437219
  --> https://bugs.webkit.org/attachment.cgi?id=437219
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=437219&action=review

r=me

> Source/JavaScriptCore/offlineasm/asm.rb:338
> +    opts.banner = "Usage: asm.rb asmFile offsetsFile outputFileName
[--assembler=<ASM> --use-deployment-location]"

Should this be "[--assembler=<ASM>] [--use-deployment-location]" instead since
the 2 options are independent?

> Source/JavaScriptCore/offlineasm/generate_offset_extractor.rb:52
> +    # This option is currently only used to specify the masm assembler

This comment is not relevant.  I think it's just copied from above.  Please
remove.

> Source/JavaScriptCore/offlineasm/generate_settings_extractor.rb:49
> +    # This option is currently only used to specify the masm assembler

Ditto.	Please remove.