[webkit-reviews] review granted: [Bug 229790] Add a layout test to detect memory leaks when drawing images to a detached canvas : [Attachment 437112] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Said Abou-Hallawa
<sabouhallawa at apple.com>'s request for review:
Bug 229790: Add a layout test to detect memory leaks when drawing images to a
detached canvas
https://bugs.webkit.org/show_bug.cgi?id=229790

Attachment 437112: Patch

https://bugs.webkit.org/attachment.cgi?id=437112&action=review




--- Comment #4 from Darin Adler <darin at apple.com> ---
Comment on attachment 437112
  --> https://bugs.webkit.org/attachment.cgi?id=437112
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=437112&action=review

> Source/WebCore/ChangeLog:3
> +	   Add a layout test to detect memory leaks when darwing images to a
detached canvas

darwing

> Source/WebKit/ChangeLog:3
> +	   Add a layout test to detect memory leaks when darwing images to a
detached canvas

darwing

> Source/WebCore/page/Page.h:584
> +    WEBCORE_EXPORT unsigned remoteImagesCount() const;

Given this is for testing only, could we have internals go directly to the
chrome client instead of putting a helper in Page?