[webkit-reviews] review granted: [Bug 229813] Buffer large media XHRs in the NetworkProcess to reduce IPC overhead : [Attachment 437180] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 229813: Buffer large media XHRs in the NetworkProcess to reduce IPC
overhead
https://bugs.webkit.org/show_bug.cgi?id=229813

Attachment 437180: Patch

https://bugs.webkit.org/attachment.cgi?id=437180&action=review




--- Comment #4 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 437180
  --> https://bugs.webkit.org/attachment.cgi?id=437180
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=437180&action=review

> Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp:652
> +	   && m_response.expectedContentLength() > static_cast<long long>(1 *
MB)

I would put this check before isMediaMIMEType because it's a cheap integer
comparison that's likely to fail.

> Source/WebKit/NetworkProcess/NetworkResourceLoader.h:213
> +    NetworkResourceLoadParameters m_parameters;

I think it would be better to mark maximumBufferingTime as mutable rather than
all the parameters as non-const.