[webkit-reviews] review denied: [Bug 229702] Add support for CSSUnparsedValue parsing through CSSStyleValue.parse() : [Attachment 437123] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Sep 2 12:08:13 PDT 2021
Alex Christensen <achristensen at apple.com> has denied review:
Bug 229702: Add support for CSSUnparsedValue parsing through
CSSStyleValue.parse()
https://bugs.webkit.org/show_bug.cgi?id=229702
Attachment 437123: Patch
https://bugs.webkit.org/attachment.cgi?id=437123&action=review
--- Comment #8 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 437123
--> https://bugs.webkit.org/attachment.cgi?id=437123
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=437123&action=review
> Source/WebCore/css/typedom/CSSStyleValue.cpp:126
> + parserContext->springTimingFunctionEnabled = true;
This should not be hard-coded. We should either get the values from a
Document, or use the default value. Can't we just use strictCSSParserContext
instead of all this?
More information about the webkit-reviews
mailing list