[webkit-reviews] review granted: [Bug 229773] [iOS] Simplify date picker logic for datetime-local inputs : [Attachment 437093] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 2 11:32:52 PDT 2021


Darin Adler <darin at apple.com> has granted Aditya Keerthi <akeerthi at apple.com>'s
request for review:
Bug 229773: [iOS] Simplify date picker logic for datetime-local inputs
https://bugs.webkit.org/show_bug.cgi?id=229773

Attachment 437093: Patch

https://bugs.webkit.org/attachment.cgi?id=437093&action=review




--- Comment #8 from Darin Adler <darin at apple.com> ---
Comment on attachment 437093
  --> https://bugs.webkit.org/attachment.cgi?id=437093
Patch

Since this relies on the format of the string, I think we should consider
comments in the code that guarantees the format, pointing here at code that
depends on the format, in case we are changing it in the future.


More information about the webkit-reviews mailing list