[webkit-reviews] review granted: [Bug 229789] Introduce PCM::Client for PrivateClickMeasurementManager : [Attachment 437110] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 2 11:13:03 PDT 2021


Kate Cheney <katherine_cheney at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 229789: Introduce PCM::Client for PrivateClickMeasurementManager
https://bugs.webkit.org/show_bug.cgi?id=229789

Attachment 437110: Patch

https://bugs.webkit.org/attachment.cgi?id=437110&action=review




--- Comment #3 from Kate Cheney <katherine_cheney at apple.com> ---
Comment on attachment 437110
  --> https://bugs.webkit.org/attachment.cgi?id=437110
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=437110&action=review

>
Source/WebKit/NetworkProcess/PrivateClickMeasurement/PrivateClickMeasurementCli
entImpl.cpp:42
> +    if (!m_networkSession)

We could use if (!featureEnabled()) here instead

>
Source/WebKit/NetworkProcess/PrivateClickMeasurement/PrivateClickMeasurementCli
entImpl.cpp:50
> +    if (!m_networkSession)

ditto


More information about the webkit-reviews mailing list