[webkit-reviews] review granted: [Bug 229059] [Web App Manifest] Always fetch the first manifest if provided : [Attachment 435634] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 2 09:53:17 PDT 2021

Brent Fulgham <bfulgham at webkit.org> has granted Devin Rousso
<drousso at apple.com>'s request for review:
Bug 229059: [Web App Manifest] Always fetch the first manifest if provided

Attachment 435634: Patch


--- Comment #5 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 435634
  --> https://bugs.webkit.org/attachment.cgi?id=435634

View in context: https://bugs.webkit.org/attachment.cgi?id=435634&action=review

> Source/WebCore/ChangeLog:4
> +	   https://bugs.webkit.org/show_bug.cgi?id=229059


> Source/WebCore/html/HTMLLinkElement.cpp:514
> +    auto media = MediaQuerySet::create(m_media,

Why did you remove the LOG statement?

> Source/WebCore/loader/DocumentLoader.cpp:1566
> +	   if (link.href().isEmpty() || !link.href().isValid())

HTMLLinkElement::href() looks kind of expensive. Would be good to only build it
once rather than three times.

More information about the webkit-reviews mailing list