[webkit-reviews] review granted: [Bug 229690] [git-webkit] Relocate contributors.json : [Attachment 437159] Part 5

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 2 09:33:11 PDT 2021


Aakash Jain <aakash_jain at apple.com> has granted Jonathan Bedard
<jbedard at apple.com>'s request for review:
Bug 229690: [git-webkit] Relocate contributors.json
https://bugs.webkit.org/show_bug.cgi?id=229690

Attachment 437159: Part 5

https://bugs.webkit.org/attachment.cgi?id=437159&action=review




--- Comment #45 from Aakash Jain <aakash_jain at apple.com> ---
Comment on attachment 437159
  --> https://bugs.webkit.org/attachment.cgi?id=437159
Part 5

View in context: https://bugs.webkit.org/attachment.cgi?id=437159&action=review

> Tools/CISupport/ews-build/steps.py:907
> +	   repo_root = os.path.dirname(os.path.dirname(os.path.dirname(cwd)))

It's fine for now, but this method of determining repo root based on location
of current file seems fragile, would be good to calculate it in some other
reliable method.


More information about the webkit-reviews mailing list