[webkit-reviews] review granted: [Bug 229788] [webkitpy] Occasional exception thrown in change_result_to_failure when repeating flaky layout tests : [Attachment 437102] Tentative patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 2 07:48:19 PDT 2021


Jonathan Bedard <jbedard at apple.com> has granted Lauro Moura
<lmoura at igalia.com>'s request for review:
Bug 229788: [webkitpy] Occasional exception thrown in change_result_to_failure
when repeating flaky layout tests
https://bugs.webkit.org/show_bug.cgi?id=229788

Attachment 437102: Tentative patch

https://bugs.webkit.org/attachment.cgi?id=437102&action=review




--- Comment #2 from Jonathan Bedard <jbedard at apple.com> ---
Comment on attachment 437102
  --> https://bugs.webkit.org/attachment.cgi?id=437102
Tentative patch

View in context: https://bugs.webkit.org/attachment.cgi?id=437102&action=review

> Tools/ChangeLog:10
> +	   Failure (likely due to r235467). This may cause
change_result_to_failure

I would be inclined to blame 240653 at main / r281216, but I don't think that
effects the validity of this change.


More information about the webkit-reviews mailing list