[webkit-reviews] review granted: [Bug 229713] Braille display is blank in contenteditable elements when the field is followed by another element. : [Attachment 437105] Patch

[bugzilla-daemon at webkit.org]

chris fleizach <cfleizach at apple.com> has granted Andres Gonzalez
<andresg_22 at apple.com>'s request for review:
Bug 229713: Braille display is blank in contenteditable elements when the field
is followed by another element.
https://bugs.webkit.org/show_bug.cgi?id=229713

Attachment 437105: Patch

https://bugs.webkit.org/attachment.cgi?id=437105&action=review




--- Comment #8 from chris fleizach <cfleizach at apple.com> ---
Comment on attachment 437105
  --> https://bugs.webkit.org/attachment.cgi?id=437105
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=437105&action=review

> Source/WebCore/accessibility/AccessibilityRenderObject.cpp:2468
> +    return it.text().length() == 1 && it.text()[0] == '\n';

is it worth caching it.text(). it must cost something to gather the text for a
range