[webkit-reviews] review granted: [Bug 229534] Add more support for JIT operation validation testing. : [Attachment 436985] proposed patch.

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Mark Lam <mark.lam at apple.com>'s
request for review:
Bug 229534: Add more support for JIT operation validation testing.
https://bugs.webkit.org/show_bug.cgi?id=229534

Attachment 436985: proposed patch.

https://bugs.webkit.org/attachment.cgi?id=436985&action=review




--- Comment #5 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 436985
  --> https://bugs.webkit.org/attachment.cgi?id=436985
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=436985&action=review

r=me

> Source/JavaScriptCore/jit/ExecutableAllocator.cpp:404
>	   g_jscConfig.startExecutableMemory =
tagCodePtr<ExecutableMemoryPtrTag>(reservation.base);
>	   g_jscConfig.endExecutableMemory =
tagCodePtr<ExecutableMemoryPtrTag>(reservationEnd);

why not remove these, and switch everyone to using some nice standalone
functions that return g_config[0] and g_config[1]?

> Source/bmalloc/bmalloc/GigacageConfig.h:107
> +constexpr size_t startSlotOfGigacageConfig = 2;

maybe it's worth commenting somewhere that the first 2 slots are for the
executable bounds?