[webkit-reviews] review granted: [Bug 229406] Add "payment" permissions policy : [Attachment 437018] Patch

[bugzilla-daemon at webkit.org]

Devin Rousso <drousso at apple.com> has granted Marcos Caceres
<marcos at marcosc.com>'s request for review:
Bug 229406: Add "payment" permissions policy
https://bugs.webkit.org/show_bug.cgi?id=229406

Attachment 437018: Patch

https://bugs.webkit.org/attachment.cgi?id=437018&action=review




--- Comment #11 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 437018
  --> https://bugs.webkit.org/attachment.cgi?id=437018
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=437018&action=review

r=me

> Source/WebCore/Modules/applepay/PaymentSession.cpp:54
> +	   return Exception { SecurityError, "Payment Request API is disabled
Permissions Policy."_s };

Can we make this error into an actual sentence?  Maybe `"Third-party iframes
are not allowed to request payments unless explicitly allowed via
Feature-Policy (payment)"`?

> Source/WebCore/Modules/paymentrequest/PaymentRequest.cpp:34
> +#include "FeaturePolicy.h"

NIT: I don't think this is needed anymore