[webkit-reviews] review granted: [Bug 229748] Eagerly resolve slot elements to simply the code in SlotAssignment : [Attachment 437003] Fixed the crash

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 229748: Eagerly resolve slot elements to simply the code in SlotAssignment
https://bugs.webkit.org/show_bug.cgi?id=229748

Attachment 437003: Fixed the crash

https://bugs.webkit.org/attachment.cgi?id=437003&action=review




--- Comment #6 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 437003
  --> https://bugs.webkit.org/attachment.cgi?id=437003
Fixed the crash

View in context: https://bugs.webkit.org/attachment.cgi?id=437003&action=review

> Source/WebCore/ChangeLog:8
> +	   This patch makes the resolution of slot elements eager. Lazily
resolution stopping making any sense

stopping -> stopped?

> Source/WebCore/ChangeLog:11
> +	   Right now, this lazy optimzation only applies when scripts
repeatedly inserts & removes a slot element

Typo: optimzation

> Source/WebCore/ChangeLog:13
> +	   and there are assigned nodes to the slot. There is no reason to
overcomplicate the slot assignemnt code

typo: assignemnt