[webkit-reviews] review denied: [Bug 228730] Replace webkit- prefix logical properties with Standard Properties in LayoutTests/ : [Attachment 436290] Patch

[bugzilla-daemon at webkit.org]

Manuel Rego Casasnovas <rego at igalia.com> has denied Sonia Singla
<soniasingla.1812 at gmail.com>'s request for review:
Bug 228730: Replace webkit- prefix logical properties with Standard Properties
in LayoutTests/
https://bugs.webkit.org/show_bug.cgi?id=228730

Attachment 436290: Patch

https://bugs.webkit.org/attachment.cgi?id=436290&action=review




--- Comment #8 from Manuel Rego Casasnovas <rego at igalia.com> ---
Comment on attachment 436290
  --> https://bugs.webkit.org/attachment.cgi?id=436290
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=436290&action=review

Nice work, thanks for the patch. Just some comments inline.

> LayoutTests/ChangeLog:32
> +	   Reviewed by NOBODY (OOPS!).

Nit: This line is usually before the description of the change.

> LayoutTests/ChangeLog:56
> +	   * fast/css/border-start-end.html:

This test is specifically testing the -webkit- prefixed property, so it doesn't
make sense to change it. Please keep it as it is.

There are more like this: margin-start-end.html, padding-start-end.html.