[webkit-reviews] review granted: [Bug 229749] [CoordinatedGraphics] Schedule rendering after setLayerTreeStateIsFrozen(false) in non-AC mode : [Attachment 437000] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 1 00:45:20 PDT 2021


Tomoki Imai <tomoki.imai at sony.com> has granted	review:
Bug 229749: [CoordinatedGraphics] Schedule rendering after
setLayerTreeStateIsFrozen(false) in non-AC mode
https://bugs.webkit.org/show_bug.cgi?id=229749

Attachment 437000: patch

https://bugs.webkit.org/attachment.cgi?id=437000&action=review




--- Comment #6 from Tomoki Imai <tomoki.imai at sony.com> ---
Created attachment 437000

  --> https://bugs.webkit.org/attachment.cgi?id=437000&action=review

patch

(In reply to Carlos Garcia Campos from comment #4)
> Comment on attachment 436991 [details]
> patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=436991&action=review
> 
> >
Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/DrawingAreaCoordinatedGrap
hics.cpp:246
> > +	 else
> > +	     scheduleDisplay();
> 
> I think we should only call this if m_layerTreeHost is nullptr

Thanks for pointing!
You're correct, I added "if (!m_layerTreeHost)" guard there.


More information about the webkit-reviews mailing list