[webkit-reviews] review granted: [Bug 229720] Add support for ServiceWorkerGlobalScope.serviceWorker : [Attachment 436965] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 229720: Add support for ServiceWorkerGlobalScope.serviceWorker
https://bugs.webkit.org/show_bug.cgi?id=229720

Attachment 436965: Patch

https://bugs.webkit.org/attachment.cgi?id=436965&action=review




--- Comment #7 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 436965
  --> https://bugs.webkit.org/attachment.cgi?id=436965
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=436965&action=review

> Source/WebCore/workers/service/context/ServiceWorkerThread.cpp:81
> +    , m_workerData(crossThreadCopy(workerData))

We do not really need a ServiceWorkerContextData&& nor a ServiceWorkerData&&,
except if we want to add a dedicated isolatedCopy() &&.

>
LayoutTests/imported/w3c/web-platform-tests/html/cross-origin-opener-policy/pop
up-coop-by-sw.https-expected.txt:1
> +CONSOLE MESSAGE: Unhandled Promise Rejection: TypeError: Load failed

This unhandled promise rejection may cause flakiness according EWS.
Can we update the test to make sure this des not happen?