[webkit-reviews] review granted: [Bug 232538] [LFC][IFC] Add unicode-bidi control characters : [Attachment 442934] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted  review:
Bug 232538: [LFC][IFC] Add unicode-bidi control characters
https://bugs.webkit.org/show_bug.cgi?id=232538

Attachment 442934: Patch

https://bugs.webkit.org/attachment.cgi?id=442934&action=review




--- Comment #6 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 442934
  --> https://bugs.webkit.org/attachment.cgi?id=442934
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=442934&action=review

> Source/WebCore/layout/formattingContexts/inline/InlineItemsBuilder.cpp:260
> +    if (enteringContentControlChar)
> +	   enterBidiContext(inlineBox, *enteringContentControlChar);
> +    if (nestedContentControlChar)
> +	   enterBidiContext(inlineBox, *nestedContentControlChar);

I think these calls could be inside the switch, avoiding the variables.

> Source/WebCore/layout/formattingContexts/inline/InlineItemsBuilder.cpp:302
> +    if (nestedContentControlChar)
> +	   exitBidiContext(inlineBox, *nestedContentControlChar);
> +    if (exitingContentControlChar)
> +	   exitBidiContext(inlineBox, *exitingContentControlChar);

Here too.