[webkit-reviews] review granted: [Bug 232538] [LFC][IFC] Add unicode-bidi control characters : [Attachment 442925] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted  review:
Bug 232538: [LFC][IFC] Add unicode-bidi control characters
https://bugs.webkit.org/show_bug.cgi?id=232538

Attachment 442925: Patch

https://bugs.webkit.org/attachment.cgi?id=442925&action=review




--- Comment #2 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 442925
  --> https://bugs.webkit.org/attachment.cgi?id=442925
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=442925&action=review

> Source/WebCore/layout/formattingContexts/inline/InlineItemsBuilder.cpp:220
>  void InlineItemsBuilder::handleInlineBox(const Box& inlineBox,
EnterInlineBox enterInlineBox, InlineItems& inlineItems)

Maybe entering/exiting could be just two separate functions?