[webkit-reviews] review denied: [Bug 232077] [GTK][WPE] Use the display refresh to drive scrolling animations (sync scroll) : [Attachment 442686] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Chris Lord
<clord at igalia.com>'s request for review:
Bug 232077: [GTK][WPE] Use the display refresh to drive scrolling animations
(sync scroll)
https://bugs.webkit.org/show_bug.cgi?id=232077

Attachment 442686: Patch

https://bugs.webkit.org/attachment.cgi?id=442686&action=review




--- Comment #11 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 442686
  --> https://bugs.webkit.org/attachment.cgi?id=442686
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=442686&action=review

> Source/WebCore/dom/Document.h:2167
> +    Vector<WeakPtr<ScrollAnimator>> m_activeScrollAnimators;

It might be OK to just traverse the set of FrameView::m_scrollableAreas. Or at
least store this as a WeakHashSet<ScrollableArea> in FrameView so it's next to
the other one.

> Source/WebCore/page/FrameView.h:742
> +    void scrollAnimatorBecameActive() final;

Please use the ...withActiveScrollAnimations/setScrollAnimationInProgress
terminology that's already in the scrolling tree.