[webkit-reviews] review granted: [Bug 228308] [WinCairo] New GraphicsLayer for GPU process mode : [Attachment 442569] Patch

[bugzilla-daemon at webkit.org]

Don Olmstead <don.olmstead at sony.com> has granted Fujii Hironori
<Hironori.Fujii at sony.com>'s request for review:
Bug 228308: [WinCairo] New GraphicsLayer for GPU process mode
https://bugs.webkit.org/show_bug.cgi?id=228308

Attachment 442569: Patch

https://bugs.webkit.org/attachment.cgi?id=442569&action=review




--- Comment #35 from Don Olmstead <don.olmstead at sony.com> ---
Comment on attachment 442569
  --> https://bugs.webkit.org/attachment.cgi?id=442569
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=442569&action=review

r=me with nits

> Source/WebCore/PlatformWinCairo.cmake:28
> +    platform/graphics/wc/RemoteGraphicsContextGLProxyBaseWC.cpp

Since this is agnostic and there is a reliance on TextureMapper maybe put these
into the WebCore/platform/TextureMapper.cmake instead in an if block.

> Source/WebKit/GPUProcess/graphics/wc/WCScene.cpp:85
> +    for (auto& layerUpdate : update.changedLayers) {

To confirm this is meant to be the same logic as
GraphicsLayerTextureMapper::commitLayerChanges() correct?

Just wondering if there's a better way so you don't have to keep them in sync.

> Source/WebKit/UIProcess/wc/DrawingAreaProxyWC.cpp:66
> +    send(Messages::DrawingArea::DidUpdate());

Just double checking this but the expectation is that an update is always
fired.