[webkit-reviews] review granted: [Bug 232460] Layout test is crashing inside WebChromeClient::createWindow : [Attachment 442755] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted Per Arne Vollan
<pvollan at apple.com>'s request for review:
Bug 232460: Layout test is crashing inside WebChromeClient::createWindow
https://bugs.webkit.org/show_bug.cgi?id=232460

Attachment 442755: Patch

https://bugs.webkit.org/attachment.cgi?id=442755&action=review




--- Comment #3 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 442755
  --> https://bugs.webkit.org/attachment.cgi?id=442755
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=442755&action=review

r=me

> Source/WebKitLegacy/mac/Plugins/Hosted/NetscapePluginHostManager.mm:315
> +	   if (hostProxy && !hostProxy->isMenuBarVisible()) {

Should we log something when we have a set of plugin hosts with no host?

Should we remove the m_pluginHosts entry if the value is nil?