[webkit-reviews] review granted: [Bug 229707] [WASM-Function-References] Add support for (ref.null heaptype) : [Attachment 442681] Patch

[bugzilla-daemon at webkit.org]

Yusuke Suzuki <ysuzuki at apple.com> has granted Dmitry <dbezhetskov at igalia.com>'s
request for review:
Bug 229707: [WASM-Function-References] Add support for (ref.null heaptype)
https://bugs.webkit.org/show_bug.cgi?id=229707

Attachment 442681: Patch

https://bugs.webkit.org/attachment.cgi?id=442681&action=review




--- Comment #5 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 442681
  --> https://bugs.webkit.org/attachment.cgi?id=442681
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=442681&action=review

r=me with nit.

> Source/JavaScriptCore/wasm/WasmAirIRGenerator.cpp:3456
> +    append(Move, Arg::bigImm(JSValue::encode(jsNull())), tmp1);
> +    append(Compare64, Arg::relCond(MacroAssembler::Equal), calleeFunction,
tmp1, tmp2);
> +    emitCheck([&] {
> +	   return Inst(BranchTest32, nullptr,
Arg::resCond(MacroAssembler::NonZero), tmp2, tmp2);
> +    }, [=] (CCallHelpers& jit, const B3::StackmapGenerationParams&) {
> +	   this->emitThrowException(jit, ExceptionType::NullReference);
> +    });

We should use Branch64 instead of Compare64 and BranchTest32.