[webkit-reviews] review granted: [Bug 232375] Ensure synchronized rendering of incoming audio tracks : [Attachment 442703] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 232375: Ensure synchronized rendering of incoming audio tracks
https://bugs.webkit.org/show_bug.cgi?id=232375

Attachment 442703: Patch

https://bugs.webkit.org/attachment.cgi?id=442703&action=review




--- Comment #5 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 442703
  --> https://bugs.webkit.org/attachment.cgi?id=442703
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=442703&action=review

r=me once the bots are happy

> Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCAudioModule.cpp:146
> +	   if (m_isRenderingIncomingAudio)
> +	      
m_incomingAudioMediaStreamTrackRendererUnit->newAudioChunkPushed();
> +	   m_currentAudioSampleCount += LibWebRTCAudioFormat::chunkSampleCount;

Is it correct to update m_currentAudioSampleCount after calling
`newAudioChunkPushed`? In either case, it might be clearer to pass sample count
to `newAudioChunkPushed()` rather than having it query the module.