[webkit-reviews] review granted: [Bug 218671] [Debug] imported/w3c/web-platform-tests/html/canvas/element/path-objects/2d.path.ellipse.basics.html is asserting : [Attachment 442719] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Nikos Mouchtaris
<nmouchtaris at apple.com>'s request for review:
Bug 218671: [Debug]
imported/w3c/web-platform-tests/html/canvas/element/path-objects/2d.path.ellips
e.basics.html is asserting
https://bugs.webkit.org/show_bug.cgi?id=218671

Attachment 442719: Patch

https://bugs.webkit.org/attachment.cgi?id=442719&action=review




--- Comment #5 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 442719
  --> https://bugs.webkit.org/attachment.cgi?id=442719
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=442719&action=review

> Source/WebCore/html/canvas/CanvasPath.cpp:148
> +    ASSERT(newStartAngle >= 0 && (newStartAngle < 2 * piFloat ||
WTF::areEssentiallyEqual<float>(newStartAngle, 2 * piFloat)));

Maybe we need an "approximately less than" helper?