[webkit-reviews] review granted: [Bug 232053] Negative length returned by TextUtil::midWordBreak with surrogate pair : [Attachment 442720] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 28 10:57:48 PDT 2021


zalan <zalan at apple.com> has granted Gabriel Nava Marino
<gnavamarino at apple.com>'s request for review:
Bug 232053: Negative length returned by TextUtil::midWordBreak with surrogate
pair
https://bugs.webkit.org/show_bug.cgi?id=232053

Attachment 442720: Patch

https://bugs.webkit.org/attachment.cgi?id=442720&action=review




--- Comment #13 from zalan <zalan at apple.com> ---
Comment on attachment 442720
  --> https://bugs.webkit.org/attachment.cgi?id=442720
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=442720&action=review

> Source/WebCore/layout/formattingContexts/inline/text/TextUtil.cpp:178
> +		   return { 0, 0 };

nitpick: it's really not important but you could write it as return { };


More information about the webkit-reviews mailing list