[webkit-reviews] review granted: [Bug 149828] Allow a way to specify a custom pixel tolerance in a ref test : [Attachment 442670] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 28 10:20:25 PDT 2021


Martin Robinson <mrobinson at webkit.org> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 149828: Allow a way to specify a custom pixel tolerance in a ref test
https://bugs.webkit.org/show_bug.cgi?id=149828

Attachment 442670: Patch

https://bugs.webkit.org/attachment.cgi?id=442670&action=review




--- Comment #21 from Martin Robinson <mrobinson at webkit.org> ---
Comment on attachment 442670
  --> https://bugs.webkit.org/attachment.cgi?id=442670
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=442670&action=review

Does this cause any new test passes? It seems like it should at least in the
WPT transforms directory.

> Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:387
> +

Nit: I think this


More information about the webkit-reviews mailing list