[webkit-reviews] review granted: [Bug 232363] Release FileSystemStorageHandle when it is not in use : [Attachment 442596] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Oct 28 09:58:19 PDT 2021
youenn fablet <youennf at gmail.com> has granted Sihui Liu <sihui_liu at apple.com>'s
request for review:
Bug 232363: Release FileSystemStorageHandle when it is not in use
https://bugs.webkit.org/show_bug.cgi?id=232363
Attachment 442596: Patch
https://bugs.webkit.org/attachment.cgi?id=442596&action=review
--- Comment #4 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 442596
--> https://bugs.webkit.org/attachment.cgi?id=442596
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=442596&action=review
> Source/WebCore/Modules/filesystemaccess/FileSystemFileHandle.cpp:69
> + FileSystem::closeFile(file);
If we need to do it there, we might have an issue as this task might be
scheduled but never executed.
Maybe we should have a result that, if destroyed and its file is valid, would
call closeFile whatever.
>
Source/WebCore/Modules/filesystemaccess/WorkerFileSystemStorageConnection.cpp:8
1
> + return;
If we do not have a scope, shouldn't we still call closeHandle?
> Source/WebCore/Modules/storage/StorageManager.cpp:125
> + connection->closeHandle(identifier);
Ditto here, should we call closeHandle if the task is not executed?
More information about the webkit-reviews
mailing list