[webkit-reviews] review granted: [Bug 178237] Support ::before and ::after pseudo elements after ::slotted : [Attachment 442680] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Antti Koivisto <koivisto at iki.fi>'s
request for review:
Bug 178237: Support ::before and ::after pseudo elements after ::slotted
https://bugs.webkit.org/show_bug.cgi?id=178237

Attachment 442680: Patch

https://bugs.webkit.org/attachment.cgi?id=442680&action=review




--- Comment #8 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 442680
  --> https://bugs.webkit.org/attachment.cgi?id=442680
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=442680&action=review

> Source/WebCore/style/ElementRuleCollector.cpp:-350
> -std::unique_ptr<RuleSet::RuleDataVector>
ElementRuleCollector::collectSlottedPseudoElementRulesForSlot()

Nice!

> Source/WebCore/style/RuleFeature.cpp:91
> +	       // FIXME: Implement accurate invalidation.
> +	       return matchElement;

Do we have a test for this?
Can we add revalidation tests since we've had a bunch of style revalidation
bugs in this area in the past?