[webkit-reviews] review granted: [Bug 232390] [WebAuthn] +[_WKWebAuthenticationPanel getAllLocalAuthenticatorCredentials] should include kSecAttrCreationDate and kSecAttrModificationDate in the data dictionaries : [Attachment 442657] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 27 17:25:55 PDT 2021


Darin Adler <darin at apple.com> has granted j_pascoe at apple.com
<j_pascoe at apple.com>'s request for review:
Bug 232390: [WebAuthn] +[_WKWebAuthenticationPanel
getAllLocalAuthenticatorCredentials] should include kSecAttrCreationDate and
kSecAttrModificationDate in the data dictionaries
https://bugs.webkit.org/show_bug.cgi?id=232390

Attachment 442657: Patch

https://bugs.webkit.org/attachment.cgi?id=442657&action=review




--- Comment #7 from Darin Adler <darin at apple.com> ---
Comment on attachment 442657
  --> https://bugs.webkit.org/attachment.cgi?id=442657
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=442657&action=review

> Source/WebKit/UIProcess/API/Cocoa/_WKWebAuthenticationPanel.mm:251
> +	   [result addObject:@ {

We normally don’t put a space after the "@" and before the "{".


More information about the webkit-reviews mailing list