[webkit-reviews] review granted: [Bug 232360] [WebKit] Enable -Wformat=2 warnings : [Attachment 442559] Patch v1

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted David Kilzer (:ddkilzer)
<ddkilzer at webkit.org>'s request for review:
Bug 232360: [WebKit] Enable -Wformat=2 warnings
https://bugs.webkit.org/show_bug.cgi?id=232360

Attachment 442559: Patch v1

https://bugs.webkit.org/attachment.cgi?id=442559&action=review




--- Comment #2 from Darin Adler <darin at apple.com> ---
Comment on attachment 442559
  --> https://bugs.webkit.org/attachment.cgi?id=442559
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=442559&action=review

> Source/WebKit/UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm:98
> +    NSString *const format = @"Experimental%@";

Consider constexpr.

> Source/WebKit/UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm:100
> +    NSString *const format = @"WebKitExperimental%@";

Consider constexpr.

> Source/WebKit/WebAuthnProcess/mac/WebAuthnProcessMac.mm:56
>      _LSSetApplicationInformationItem(kLSDefaultSessionID,
_LSGetCurrentApplicationASN(), _kLSDisplayNameKey,
(CFStringRef)applicationName, nullptr);

bridge_cast?