[webkit-reviews] review granted: [Bug 232390] [WebAuthn] +[_WKWebAuthenticationPanel getAllLocalAuthenticatorCredentials] should include kSecAttrCreationDate and kSecAttrModificationDate in the data dictionaries : [Attachment 442612] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted j_pascoe at apple.com
<j_pascoe at apple.com>'s request for review:
Bug 232390: [WebAuthn] +[_WKWebAuthenticationPanel
getAllLocalAuthenticatorCredentials] should include kSecAttrCreationDate and
kSecAttrModificationDate in the data dictionaries
https://bugs.webkit.org/show_bug.cgi?id=232390

Attachment 442612: Patch

https://bugs.webkit.org/attachment.cgi?id=442612&action=review




--- Comment #3 from Darin Adler <darin at apple.com> ---
Comment on attachment 442612
  --> https://bugs.webkit.org/attachment.cgi?id=442612
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=442612&action=review

> Source/WebKit/UIProcess/API/Cocoa/_WKWebAuthenticationPanel.mm:256
> +	       _WKLocalAuthenticatorCredentialIDKey :
attributes[bridge_id_cast(kSecAttrApplicationLabel)],
> +	       _WKLocalAuthenticatorCredentialRelyingPartyIDKey :
attributes[bridge_id_cast(kSecAttrLabel)],
> +	       _WKLocalAuthenticatorCredentialLastModificationDateKey :
attributes[bridge_id_cast(kSecAttrModificationDate)],
> +	       _WKLocalAuthenticatorCredentialCreationDateKey :
attributes[bridge_id_cast(kSecAttrCreationDate)]

bridge_cast also works here, and I suggest always using bridge_cast unless you
must use bridge_id cast.

Also, there’s a formatting change here where you are added spaces before the
colons and before the "{", and I am not sure why.