[webkit-reviews] review granted: [Bug 232403] AutoInstall should have separate install directories per CPU architecture : [Attachment 442635] proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 27 14:15:46 PDT 2021


Jonathan Bedard <jbedard at apple.com> has granted Alexey Proskuryakov
<ap at webkit.org>'s request for review:
Bug 232403: AutoInstall should have separate install directories per CPU
architecture
https://bugs.webkit.org/show_bug.cgi?id=232403

Attachment 442635: proposed patch

https://bugs.webkit.org/attachment.cgi?id=442635&action=review




--- Comment #2 from Jonathan Bedard <jbedard at apple.com> ---
Comment on attachment 442635
  --> https://bugs.webkit.org/attachment.cgi?id=442635
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=442635&action=review

> Tools/Scripts/webkitpy/__init__.py:35
> +AutoInstall.set_directory(os.path.join(libraries, 'autoinstalled',
'python-{}-{}'.format(sys.version_info[0], platform.machine())))

This looks good, the only issue is that we're going to force a re-install of
everything because python-3 will now be python-3-arm64, but that seems like an
acceptable cost.


More information about the webkit-reviews mailing list