[webkit-reviews] review granted: [Bug 232120] REGRESSION (r284650-284661): [iOS15 Sim] imported/w3c/web-platform-tests/content-security-policy/script-src/script-src-multiple-policies-multiple-hashing-algorithms.html is a text failure : [Attachment 442616] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted Kate Cheney
<katherine_cheney at apple.com>'s request for review:
Bug 232120: REGRESSION (r284650-284661): [iOS15 Sim]
imported/w3c/web-platform-tests/content-security-policy/script-src/script-src-m
ultiple-policies-multiple-hashing-algorithms.html is a text failure
https://bugs.webkit.org/show_bug.cgi?id=232120

Attachment 442616: Patch

https://bugs.webkit.org/attachment.cgi?id=442616&action=review




--- Comment #7 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 442616
  --> https://bugs.webkit.org/attachment.cgi?id=442616
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=442616&action=review

r=me

> Source/WebCore/page/csp/ContentSecurityPolicy.cpp:374
> +    Vector<ContentSecurityPolicyHash> hashes;

If we might have many hashes, we could preallocate hashes for the size of
algorithms, but maybe we only ever have a handful.

> Source/WebCore/page/csp/ContentSecurityPolicy.cpp:376
>	   ContentSecurityPolicyHash hash =
cryptographicDigestForBytes(algorithm, encodedContent.data(),
encodedContent.size());

This could be auto