[webkit-reviews] review denied: [Bug 37984] [Freetype] Support for "locl" tables : [Attachment 442519] Patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has denied Arcady Goldmints-Orlov
<agoldmints at igalia.com>'s request for review:
Bug 37984: [Freetype] Support for "locl" tables
https://bugs.webkit.org/show_bug.cgi?id=37984

Attachment 442519: Patch

https://bugs.webkit.org/attachment.cgi?id=442519&action=review




--- Comment #49 from Martin Robinson <mrobinson at webkit.org> ---
Comment on attachment 442519
  --> https://bugs.webkit.org/attachment.cgi?id=442519
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=442519&action=review

This is great! Looks like the test is still failing on Mac and this should
handle a failed call to hb_language_from_string, but this is a good start.

>
Source/WebCore/platform/graphics/harfbuzz/ComplexTextControllerHarfBuzz.cpp:548
> +    hb_language_t language = hb_language_from_string(reinterpret_cast<const
char*>(m_font.fontDescription().computedLocale().characters8()), -1);

I think it would be better to do this here:

hb_language_from_string(m_font.fontDescription().computedLocale().string().toUT
F8().data()), -1);

This would allow you to avoid the reinterpret_cast.

It seems like this call should check for and handle (not set the language
below) the situation where HB_LANGUAGE_INVALID is returned here.