[webkit-reviews] review granted: [Bug 232352] Store WPT-style fuzzy pixel matching data in ImageDiffResult : [Attachment 442542] Patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 232352: Store WPT-style fuzzy pixel matching data in ImageDiffResult
https://bugs.webkit.org/show_bug.cgi?id=232352

Attachment 442542: Patch

https://bugs.webkit.org/attachment.cgi?id=442542&action=review




--- Comment #2 from Martin Robinson <mrobinson at webkit.org> ---
Comment on attachment 442542
  --> https://bugs.webkit.org/attachment.cgi?id=442542
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=442542&action=review

> Tools/Scripts/webkitpy/port/image_diff.py:147
> +	   m = re.match(b'maxDifference=(\d+); totalPixels=(\d+)', fuzzy_data)

I think this should be:

m = re.match(br'maxDifference=(\d+); totalPixels=(\d+)', fuzzy_data)

which is the source of the style bot failure.