[webkit-reviews] review granted: [Bug 215438] [JSC] Implement IntlNumberFormat v3 : [Attachment 442558] Patch

[bugzilla-daemon at webkit.org]

Ross Kirsling <ross.kirsling at sony.com> has granted Yusuke Suzuki
<ysuzuki at apple.com>'s request for review:
Bug 215438: [JSC] Implement IntlNumberFormat v3
https://bugs.webkit.org/show_bug.cgi?id=215438

Attachment 442558: Patch

https://bugs.webkit.org/attachment.cgi?id=442558&action=review




--- Comment #27 from Ross Kirsling <ross.kirsling at sony.com> ---
Comment on attachment 442558
  --> https://bugs.webkit.org/attachment.cgi?id=442558
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=442558&action=review

r=me

> Source/JavaScriptCore/runtime/IntlNumberFormat.cpp:422
> +    m_roundingMode = intlOption<RoundingMode>(globalObject, options,
vm.propertyNames->roundingMode, {

I think ultimately we should update temporalRoundingMode and use it here (or
actually probably turn it into intlRoundingMode and use it from Temporal)?
But I guess we could wait for that spec to actually get updated with the
intended behaviors.

> Source/JavaScriptCore/runtime/MathCommon.h:68
> +    return std::signbit(value) && value == 0;

I think the style checker prefers `!value`?