[webkit-reviews] review granted: [Bug 232336] WKAPI does not have any APIs to set cookie path to WKWebsiteDataStoreConfigurationRef : [Attachment 442538] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has granted Takashi Komori
<takashi.komori at sony.com>'s request for review:
Bug 232336: WKAPI does not have any APIs to set cookie path to
WKWebsiteDataStoreConfigurationRef
https://bugs.webkit.org/show_bug.cgi?id=232336

Attachment 442538: Patch

https://bugs.webkit.org/attachment.cgi?id=442538&action=review




--- Comment #3 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 442538
  --> https://bugs.webkit.org/attachment.cgi?id=442538
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=442538&action=review

This is reasonable but the test needs some love.

> Tools/TestWebKitAPI/PlatformPlayStation.cmake:33
> +	   Tests/WebKit/curl/CookieStorageFile.cpp

There's nothing curl-specific about this test.

> Tools/TestWebKitAPI/Tests/WebKit/curl/CookieStorageFile.cpp:76
> +    WKPageConfigurationSetContext(pageConfiguration.get(), context.get());

This doesn't do anything.

> Tools/TestWebKitAPI/Tests/WebKit/curl/CookieStorageFile.cpp:84
> +    loaderClient.base.clientInfo = this;

Instead of using a static bool didFinishLoad, use a local bool didFinishLoad
and point clientInfo at it.  Or put m_didFinishLoad in the CookieStorageFile
class.