[webkit-reviews] review requested: [Bug 232354] webkitdirs.pm should use JSON::XS when available : [Attachment 442544] proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 26 17:08:04 PDT 2021


Alexey Proskuryakov <ap at webkit.org> has asked  for review:
Bug 232354: webkitdirs.pm should use JSON::XS when available
https://bugs.webkit.org/show_bug.cgi?id=232354

Attachment 442544: proposed patch

https://bugs.webkit.org/attachment.cgi?id=442544&action=review




--- Comment #1 from Alexey Proskuryakov <ap at webkit.org> ---
Created attachment 442544

  --> https://bugs.webkit.org/attachment.cgi?id=442544&action=review

proposed patch

It's intentional that the script doesn't die if import fails - there is a lot
of functionality that doesn't require JSON, so it's better to not break
everything even in the super unlikely case that JSON::PP cannot be loaded.


More information about the webkit-reviews mailing list